Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11065] Remove usage of App Engine Mail API #11068

Merged
merged 1 commit into from
Mar 28, 2021
Merged

[#11065] Remove usage of App Engine Mail API #11068

merged 1 commit into from
Mar 28, 2021

Conversation

wkurniawan07
Copy link
Member

Fixes #11065

Derek-Hardy
Derek-Hardy approved these changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@Derek-Hardy Derek-Hardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wkurniawan07 wkurniawan07 added the s.ToReview The PR is waiting for review(s) label Mar 27, 2021
jianhandev
jianhandev approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@jianhandev jianhandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkurniawan07 wkurniawan07 merged commit 7744a2e into TEAMMATES:teammatesv8 Mar 28, 2021
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Mar 28, 2021
@wkurniawan07 wkurniawan07 added this to the V8.0.0 milestone Mar 28, 2021
@wkurniawan07 wkurniawan07 deleted the runtime-upgrade/mail branch March 28, 2021 16:56
wkurniawan07 added a commit that referenced this pull request Apr 28, 2021
@wkurniawan07
[#11065] Remove usage of App Engine Mail API (#11068)
f6ff503
wkurniawan07 added a commit that referenced this pull request May 3, 2021
@wkurniawan07
[#11065] Remove usage of App Engine Mail API (#11068)
b5b3bfa
wkurniawan07 added a commit that referenced this pull request Jun 2, 2021
@wkurniawan07
[#11065] Remove usage of App Engine Mail API (#11068)
dfcec13
wkurniawan07 added a commit that referenced this pull request Jun 6, 2021
@wkurniawan07
[#11065] Remove usage of App Engine Mail API (#11068)
c8d504f
@wkurniawan07 wkurniawan07 added c.Task Other non-user-facing works, e.g. refactoring, adding tests c.DevOps Process-related or build-related improvement and addition and removed c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jun 6, 2021
wkurniawan07 added a commit that referenced this pull request Jun 6, 2021
@wkurniawan07
[#11065] Remove usage of App Engine Mail API (#11068)
0df8ddf
daongochieu2810 pushed a commit to daongochieu2810/teammates that referenced this pull request Jul 5, 2021
@wkurniawan07 @daongochieu2810
[TEAMMATES#11065] Remove usage of App Engine Mail API (TEAMMATES#11068)
1be0e37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianhandev jianhandev jianhandev approved these changes

@Derek-Hardy Derek-Hardy Derek-Hardy approved these changes

Assignees

@Derek-Hardy Derek-Hardy

@jianhandev jianhandev

Labels
c.DevOps Process-related or build-related improvement and addition s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wkurniawan07 @Derek-Hardy @jianhandev