-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11018] Implement Google OAuth 2.0 to replace Users API #11073
Merged
wkurniawan07
merged 13 commits into
TEAMMATES:teammatesv8
from
wkurniawan07:runtime-upgrade/auth
Apr 13, 2021
Merged
[#11018] Implement Google OAuth 2.0 to replace Users API #11073
wkurniawan07
merged 13 commits into
TEAMMATES:teammatesv8
from
wkurniawan07:runtime-upgrade/auth
Apr 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkurniawan07
force-pushed
the
runtime-upgrade/auth
branch
from
April 9, 2021 15:31
76c4c29
to
671f33b
Compare
madanalogy
reviewed
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't take a close look at E2E changes as I'm not very familiar with them. Changes otherwise looks good, just one suggestion below
src/main/java/teammates/common/datatransfer/UserInfoCookie.java
Outdated
Show resolved
Hide resolved
wkurniawan07
force-pushed
the
runtime-upgrade/auth
branch
from
April 12, 2021 14:44
671f33b
to
cc0b4d0
Compare
wkurniawan07
force-pushed
the
runtime-upgrade/auth
branch
from
April 12, 2021 15:28
cc0b4d0
to
b922795
Compare
madanalogy
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
madanalogy
added
s.FinalReview
The PR is ready for final review
and removed
s.ToReview
The PR is waiting for review(s)
labels
Apr 13, 2021
wkurniawan07
added
s.ToMerge
The PR is approved by all reviewers including final reviewer; ready for merging
and removed
s.FinalReview
The PR is ready for final review
labels
Apr 13, 2021
wkurniawan07
added a commit
that referenced
this pull request
Apr 28, 2021
wkurniawan07
added a commit
that referenced
this pull request
May 3, 2021
wkurniawan07
added a commit
that referenced
this pull request
Jun 2, 2021
wkurniawan07
added a commit
that referenced
this pull request
Jun 6, 2021
wkurniawan07
added
c.Task
Other non-user-facing works, e.g. refactoring, adding tests
c.DevOps
Process-related or build-related improvement and addition
and removed
c.Task
Other non-user-facing works, e.g. refactoring, adding tests
labels
Jun 6, 2021
wkurniawan07
added a commit
that referenced
this pull request
Jun 6, 2021
daongochieu2810
pushed a commit
to daongochieu2810/teammates
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11018
This is security-related which I do not have much expertise on, so I'd appreciate all inputs.
List of things done:
web.xml
as this "admin" privilege is coupled with the privilege in the Google Cloud IAM.Some implementation details:
HttpOnly
flag, and additionalSecure
flag for production server, and is persisted for 7 days.state
parameter containing an encrypted data structure.build.properties
file.