Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12517] Instructors creating sessions: response visible time should be 'not now' by default #12518

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[#12517] Instructors creating sessions: response visible time should be 'not now' by default #12518

merged 1 commit into from
Jul 14, 2023

Conversation

Zxun2
Copy link
Contributor

@Zxun2 Zxun2 commented Jul 14, 2023

Fixes #12517

Outline of Solution

Overwrite default attributes inherited from base class.

domlimm
domlimm approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the hotfix ZX!

@domlimm domlimm requested a review from weiquu July 14, 2023 15:43
weiquu
weiquu approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weiquu weiquu merged commit 02bf5c2 into TEAMMATES:master Jul 14, 2023
@samuelfangjw
Copy link
Member

Thanks @Zxun2, @domlimm, @weiquu for the quick fix!

@samuelfangjw samuelfangjw added c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging labels Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.1 milestone Jul 14, 2023
@damithc
Copy link
Contributor

damithc commented Jul 14, 2023

Thanks @Zxun2, @domlimm, @weiquu for the quick fix!

Yup 💯

samuelfangjw pushed a commit that referenced this pull request Jul 15, 2023
@Zxun2 @samuelfangjw
[#12517] Instructors creating sessions: response visible time should …
f2ec14f 
…be 'not now' by default (#12518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@domlimm domlimm domlimm approved these changes

Assignees

@domlimm domlimm

@weiquu weiquu

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.28.1
Development

Successfully merging this pull request may close these issues.

Instructors creating sessions: response visible time should be 'not now' by default
5 participants
@Zxun2 @samuelfangjw @damithc @domlimm @weiquu