[#12329] Refactoring of sortable tables - Extension Confirm Modal #12556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
1 similar comment
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Hey @jasonqiu212 @weiquu @cedricongjh, this PR is also ready for review |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
cedricongjh
approved these changes
Sep 17, 2023
10 tasks
jasonqiu212
added
s.ToMerge
wkurniawan07
added
the
c.Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12329
Outline of Solution
This PR refactors the student and instructor tables created in the modal to utilise the
sortable-tablecomponent. The solution roughly encompasses the same mechanics as other similar refactoring PRs.UI and functionality should be maintained for the modal.