[#12588] Added unit tests for ErrorReportComponent #12610
Conversation
|
Hi @u7488099, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
u7488099
changed the title
|
Ready for review |
| it('should inject ErrorReportService and NgbActiveModal', () => { | ||
| const errorReportService = (component as any).errorReportService; | ||
| const ngbActiveModal = (component as any).ngbActiveModal; | ||
|
|
||
| expect(errorReportService).toBeTruthy(); | ||
| expect(ngbActiveModal).toBeTruthy(); | ||
| }); |
There was a problem hiding this comment.
let's remove this test as it's using type assertions (component as any) to access private properties of the component, which is not a recommended practice because it breaks encapsulation, and moreover, we are already testing these 2 services indirectly through the public methods of the classs
|
The test has been removed |
|
Ready for review |
|
Ready for review |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
1 similar comment
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢 |
weiquu
added
s.ToMerge
wkurniawan07
added
the
c.Task
…S#12610) * [TEAMMATES#12588] Added unit tests for ErrorReportComponent * [TEAMMATES#12588] Added unit tests for ErrorReportComponent * [TEAMMATES#12588] Added unit tests for ErrorReportComponent * [TEAMMATES#12588] Added unit tests for ErrorReportComponent * [TEAMMATES#12588] Fixed Added unit tests for ErrorReportComponent --------- Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Fixes [#12588]
Outline of Solution
Add unit tests for ErrorReportComponent