Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12657] Instructor Home Page: Students dropdown buttons of the wrong colour . #12691

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

SArora12
Copy link
Contributor

Fixes #12657

Outline of Solution

I have changed the required classes in "teammates\src\web\app\pages-instructor\instructor-home-page\instructor-home-page.component.html" and in "teammates\src\web\app\pages-instructor\instructor-home-page_snapshots_\instructor-home-page.component.spec.ts.snap" . I expect this updation will work well. Let me know if there is anything else you want to change.

Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@domlimm domlimm added the s.FinalReview The PR is ready for final review label Jan 18, 2024
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu merged commit 8b428f8 into TEAMMATES:master Jan 20, 2024
10 checks passed
@wkurniawan07 wkurniawan07 added c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 modified the milestones: V8.29.0, V8.30.0 Jan 21, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor Home Page: Students dropdown buttons of the wrong colour
4 participants