Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12692] Update Angular to 16 and Node to 18 #12694

Merged
merged 10 commits into from
Jan 26, 2024
Merged

[#12692] Update Angular to 16 and Node to 18 #12694

merged 10 commits into from
Jan 26, 2024

Conversation

wkurniawan07
Copy link
Member

Fixes #12692

@wkurniawan07 wkurniawan07 marked this pull request as ready for review January 24, 2024 01:53
@cedricongjh cedricongjh self-requested a review January 24, 2024 14:00
cedricongjh
cedricongjh approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested out, lgtm!

@wkurniawan07 wkurniawan07 merged commit 09024c5 into TEAMMATES:master Jan 26, 2024
9 checks passed
@wkurniawan07 wkurniawan07 deleted the a16 branch January 26, 2024 02:47
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 26, 2024
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests c.DevOps Process-related or build-related improvement and addition and removed c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 26, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@wkurniawan07 @cedricongjh
[TEAMMATES#12692] Update Angular to 16 and Node to 18 (TEAMMATES#12694)
72055ff 
* Fix duplicate comment button bug in question submission

* Update front-end dependencies, Angular to 16

* Update Angular app configurations

* Update implementation code

* Update test settings + snapshot

* Fix new eslint violations

* Update stylelint, add prettier to lint for aesthetic-only issues

* Make Node.js 18 the minimum requirement

* Add BaseAxeTestCase with ability to selectively ignore issues

* Make all Axe tests inherit BaseAxeTestCase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
c.DevOps Process-related or build-related improvement and addition s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Update Angular to 16 and Node to 18/20
2 participants
@wkurniawan07 @cedricongjh