Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12653] Copy course modal: Mandatory fields not highlighted #12703

Closed

Conversation

leojiangxd
Copy link

@leojiangxd leojiangxd commented Jan 25, 2024

Fixes #12653

Tried to replicate solution in [#12617].

Copy link

Hi @leojiangxd, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@leojiangxd leojiangxd changed the title [#12687] Copy course modal: Mandatory fields not highlighted [#12653] Copy course modal: Mandatory fields not highlighted Jan 25, 2024
@weiquu
Copy link
Contributor

weiquu commented Jan 27, 2024

Hi @leojiangxd, do fix the failing checks. You can click on 'Details' to see more information. In particular, it seems like the lint check (npm run lint) and the snapshot tests are failing.

@cedricongjh cedricongjh added the s.Ongoing The PR is being worked on by the author(s) label Feb 19, 2024
@cedricongjh
Copy link
Contributor

closing due to inactivity, do reopen the PR if you're continuing work on the issue

@cedricongjh cedricongjh closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy course modal: Mandatory fields not highlighted
3 participants