Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Prepare Patch Data Migration Script for Account #12883

Merged
merged 2 commits into from
Mar 10, 2024
Merged

[#12048] Prepare Patch Data Migration Script for Account #12883

merged 2 commits into from
Mar 10, 2024

Conversation

ziqing26
Copy link
Contributor

Part of #12048

Outline of Solution

  • To enable patch update of accounts for data migration, we decide to use the isMigrated flag in Account.
  • If the account is migrated in the online update, the isMigrated flag will be set to true.
  • Then when we do patch update in the offline migration for Account and ReadNotification, we check this flag to determine if this account has been migrated or not.

@ziqing26 ziqing26 marked this pull request as ready for review March 10, 2024 09:42
cedricongjh
cedricongjh approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ziqing26 ziqing26 merged commit 2caea93 into TEAMMATES:master Mar 10, 2024
10 of 11 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.1 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricongjh cedricongjh cedricongjh approved these changes

@FergusMok FergusMok Awaiting requested review from FergusMok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V9.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ziqing26 @cedricongjh