Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Fix get feedback sessions action #12886

Merged

Conversation

cedricongjh
Copy link
Contributor

@cedricongjh cedricongjh commented Mar 11, 2024

Part of #12048

Outline of Solution
Fix GetFeedbackSessionsAction logic to query both SQL and Datastore
Change StudentHomePageE2ETest verifyVisibleCourseToStudents to search all panels, rather than assume that it's ordered on the page

@cedricongjh cedricongjh added the s.ToReview The PR is waiting for review(s) label Mar 11, 2024
Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@cedricongjh cedricongjh merged commit e385eed into TEAMMATES:master Mar 12, 2024
11 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.1 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToReview The PR is waiting for review(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants