[#12048] Add deep comparison for entities in verifyEquals for E2E
#12892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
domlimm
force-pushed
the
v9-verify-equals-entities
branch
from
7c6d31d
to
16a2ce7
Compare
domlimm
added
s.ToReview
domlimm
force-pushed
the
v9-verify-equals-entities
branch
from
a482ee3
to
e4136b9
Compare
cedricongjh
reviewed
Mar 18, 2024
Comment on lines
73
to
74
| assertEquals(expectedQuestionDetails.getQuestionText(), actualQuestion.getQuestionBrief()); | ||
| assertEquals(expectedQuestionDetails.getQuestionType(), actualQuestion.getQuestionType()); |
There was a problem hiding this comment.
we should compare the json string of the question details, similar to feedbackresponse
cedricongjh
reviewed
Mar 18, 2024
Comment on lines
160
to
161
| assertEquals(expectedStudent.getTeamName(), actualStudent.getTeamName()); | ||
| assertEquals(expectedStudent.getSectionName(), actualStudent.getSectionName()); |
There was a problem hiding this comment.
for getTeamName and getSectionName, there might be null pointer exceptions as a student might not have a team or section, let's comment these out and fix this bug in another PR
There was a problem hiding this comment.
ah that makes sense. thank you!
domlimm
force-pushed
the
v9-verify-equals-entities
branch
from
0f94dec
to
0427b6f
Compare
domlimm
force-pushed
the
v9-verify-equals-entities
branch
from
0427b6f
to
048dc3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048.