[#12921] Reintroduce AccountRequest search indexing #12923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayasting98
added
s.Ongoing
jayasting98
added
s.ToReview
jayasting98
requested review from
kevin9foong,
weiquu,
cedricongjh and
ziqing26
ziqing26
approved these changes
Mar 22, 2024
jayasting98
added
s.FinalReview
NicolasCwy
approved these changes
Mar 22, 2024
NicolasCwy
added
the
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12921
Part of #12048
Outline of Solution
Search indexing for
AccountRequestwas reintroduced. There were effectively no integration tests forCreateAccountRequestAction;teammates.ui.webapi.CreateAccountRequestActionTestis not enabled, and even if it were, it tests using Datastore, not SQL. Thus, I also addedCreateAccountRequestActionIT. However, I only give a minimal test because the behaviour ofCreateAccountRequestActionwill change with the upcoming account request form upgrade (see #12913). I felt it would not be very productive to test every single case. The minimal test only serves to give confidence that the core functionality ofCreateAccountRequestActionworks, especially the newly reintroduced search indexing.