Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12901] Check if the search service is active in account request search test #13101

Merged
merged 18 commits into from
Jun 28, 2024
Merged

[#12901] Check if the search service is active in account request search test #13101

merged 18 commits into from
Jun 28, 2024

Conversation

cliu585
Copy link
Contributor

@cliu585 cliu585 commented Apr 29, 2024

Fixes #12901

  • Added check for active service in account search request test
  • Moved account search request test to AccountRequestSearchIT.java and updated variables and asserts accordingly

Carolyn Liu and others added 15 commits April 27, 2024 22:26
added check for active search service in account request search test
1a2b2c2
moved account request search test to AccountRequestSearchIT and updat…
aadf8a3 
…ed variables and asserts accordingly
@cliu585
Merge branch 'master' into test-search-service-active
a459ffc
@cliu585
Merge pull request #1 from cliu585/test-search-service-active
e33e88b 
[TEAMMATES#12901] Check if the search service is active in account request search test
@azhang49
Add caution note to instructor email copies and remove hyperlinks
232c757
updated account request test constructor to be consistent with latest…
88dbc7d 
… commits
fixed style errors
7cfc153
@azhang49
Merge branch 'master' of https://github.com/cliu585/teammates
9259c7c
@cliu585
Merge pull request #2 from cliu585/test-search-service-active
15d39fd 
Fixed compiler errors from the first pull request
fixed compiler errors
0cbbdfc
@cliu585
Merge pull request #3 from cliu585/test-search-service-active
823fa37 
Fixed further compiler errors resulting from the second pull request
fixed assertion error and style
6c0835d
fixed linter errors
88c565e
@cliu585
Merge pull request #4 from cliu585/test-search-service-active
ed0020a 
Fixed assertion error and style
@cliu585
Revert "Add caution note to instructor email copies and remove hyperl…
0b9acb0 
…inks"

This reverts commit 232c757.
jayasting98
jayasting98 reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution. There is already an open PR for this, #13021, so unless that one is closed, perhaps we will put your PR on hold for now.

Feel free to work on another issue if you still want to.

@jayasting98 jayasting98 added s.OnHold The issue/PR's validity has been put on hold pending some other event c.Task Other non-user-facing works, e.g. refactoring, adding tests labels May 7, 2024
@itstrueitstrueitsrealitsreal itstrueitstrueitsrealitsreal mentioned this pull request Jun 16, 2024
Closed
weiquu
weiquu approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu merged commit 015b872 into TEAMMATES:master Jun 28, 2024
11 checks passed
@weiquu weiquu added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.OnHold The issue/PR's validity has been put on hold pending some other event labels Jun 28, 2024
@weiquu weiquu mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayasting98 jayasting98 jayasting98 left review comments

@weiquu weiquu weiquu approved these changes

Assignees

@cliu585 cliu585

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if the search service is active in account request search test
5 participants
@cliu585 @weiquu @jayasting98 @azhang49 @dishenggg