Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13103]Account request form: No need to CC the email 'Acknowledgement of Instructor Account Request' #13116

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[#13103]Account request form: No need to CC the email 'Acknowledgement of Instructor Account Request' #13116

merged 3 commits into from
Jun 12, 2024

Conversation

Ashwinn11
Copy link
Contributor

@Ashwinn11 Ashwinn11 commented May 20, 2024 •
edited
Loading

Fixes #13103

  • Removed BCC from the ACK email sent to users upon account request submission.
  • Updated relevant test cases to reflect the changes.

@github-actions GitHub Actions
Copy link

Hi @Ashwinn11, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@Ashwinn11
Copy link
Contributor Author

waiting for review

@Ashwinn11 Ashwinn11 changed the title [#13103] Fixes #13103 - Removed admin BCC from ACK email [#13103]Account request form: No need to CC the email 'Acknowledgement of Instructor Account Request' May 23, 2024
jayasting98
jayasting98 approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. That should work. The tests are failing on GitHub Actions, but it does not seem to be due to this PR, so I think this should be okay.

@jayasting98 jayasting98 added c.Bug Bug/defect report s.FinalReview The PR is ready for final review labels May 29, 2024
domoberzin
domoberzin approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failing tests should be unrelated to this PR

@domoberzin domoberzin added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jun 6, 2024
@wkurniawan07 wkurniawan07 added c.Feature User-facing feature; can be new feature or enhancement to existing feature and removed c.Bug Bug/defect report labels Jun 12, 2024
@wkurniawan07 wkurniawan07 merged commit 6114677 into TEAMMATES:master Jun 12, 2024
11 checks passed
@Ashwinn11 Ashwinn11 deleted the fix-13103 branch June 12, 2024 06:27
@Ashwinn11 Ashwinn11 restored the fix-13103 branch June 12, 2024 06:28
@Ashwinn11 Ashwinn11 deleted the fix-13103 branch June 12, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoberzin domoberzin domoberzin approved these changes

@jayasting98 jayasting98 jayasting98 approved these changes

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@Ashwinn11 Ashwinn11

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account request form: No need to CC the email 'Acknowledgement of Instructor Account Request'
5 participants
@Ashwinn11 @wkurniawan07 @jayasting98 @domoberzin @dishenggg