Upgrade to Webpack 4 #8712 #8713
Conversation
There was a problem hiding this comment.
@crphang Thanks for taking the time to look into this!
We will need to impose a newer Node.js version in the setting-up guide. Based on the release note of Webpack 4.0.0, Node 4 is no longer supported, and based on this tweet, Node 8.9.4+ is recommended. Also take a look at webpack/webpack#6579; I don't know how true/reliable it is.
Also, I hope this has been tested in AppVeyor or some other Windows-based environment?
webpack-test.config.js
Outdated
| @@ -25,6 +25,7 @@ const babel = { | |||
|
|
|||
| module.exports = { | |||
| entry, | |||
| mode: 'production', | |||
There was a problem hiding this comment.
Is this needed? Even if deployed, this remains a testing-only file.
There was a problem hiding this comment.
Ah. It's not strictly necessary here. What it does is that it allows for various production environment only optimization, which includes minimizer (UglifyJS). But since we don't use it for test, we can leave it out for now.
There was a problem hiding this comment.
I'll look into the node requirements and windows environment. Missed that since my local machine has a later version.
There was a problem hiding this comment.
Tried and tested this on my windows setup and it works fine.
AppVeyor also working as expected https://ci.appveyor.com/project/tshradheya/teammates/build/1.0.22
package.json
Outdated
| @@ -10,7 +10,8 @@ | |||
| "lintspaces-cli": "0.6.0", | |||
| "stylelint": "9.1.1", | |||
| "stylelint-config-standard": "18.2.0", | |||
| "webpack": "3.11.0" | |||
| "webpack": "4.2.0", | |||
There was a problem hiding this comment.
@crphang Any reason why version 4.2?
When I did npm install webpack , it installed the 4.3.0 version
There was a problem hiding this comment.
The docs currently is for 4.2 on Webpack official docs. I thought its good to follow that. Later versions of 4.x shouldnt have breaking changes, and can be upgraded iteratively. What do you guys think?
There was a problem hiding this comment.
Keeping 4.2 sounds fine to me in that case 👍
There was a problem hiding this comment.
The docs currently is for 4.2 on Webpack official docs.
Are you sure? I just checked and it's already updated to 4.3.0 which was released only yesterday. I believe it's safe to use the latest version.
Clearly we can't be up-to-date all the time unless we use a non-exact versioning policy, but this shall be a discussion for another day.
There was a problem hiding this comment.
My folly, didnt check the most recent since my change was super recent as well. Will update it!
Thanks @tshradheya for the windows verification
wkurniawan07
added
s.ToMerge
crphang
changed the title
whipermr5
added
the
c.DevOps
Fixes #8712
Outline of Solution
There is currently not many webpack dependencies other than UglifyJSPlugin that is affected. Upgraded webpack and installed webpack-cli (separated from webpack in webpack 4). Modified code to support UglifyJSPlugin.
Currently mode is set to production by default, which is similar to how we are doing things. This upgrade ensures that dependencies does not break and does not introduce new upgrades (will be part of upcoming issues and PRs).