ProfilesDbTest.testUpdateStudentProfile failing on live server #8958 #8966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tshradheya This time we need to run the complete set of tests to ensure there is no other problem. |
|
@xpdavid Ran all tests on the live server and reverted changes that caused regression. These changes solve the issue and dont introduce any other problem |
tshradheya
force-pushed
the
profilesdb-fix-test
branch
from
2c1d7ca
to
260de2f
Compare
xpdavid
approved these changes
Jul 17, 2018
There was a problem hiding this comment.
@wkurniawan07 Any inputs?
Background: Setting environemnt to production cause problems in other tests while Config.APP_URL needs the production environment to produce correct URL in pre-deployment statging test.
|
Going to merge to prevent any failing in V6.8.0. @wkurniawan07 feel free to raise comments if any. |
xpdavid
added
s.FinalReview
damithc
approved these changes
Jul 29, 2018
damithc
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8958
Outline of Solution
isDevServerwork butisDevServerworks only for appengine instance.TestProperties.TEST_URLwithConfig.APP_URLI have run a few tests(EmailGenerator, AdminHomePageUiTest, ProfilesDbTest) on live server which failed in 6.6.0(and were fixed in 6.7.0) and they now pass on live server.