Student: Comment on responses: Fix put document error #9034 #9035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xpdavid Put comment document was failing silently because comment id was null. Please review. |
xpdavid
reviewed
Aug 10, 2018
| @@ -307,7 +307,7 @@ private void saveNewCommentsByFeedbackParticipant(List<FeedbackResponseCommentAt | |||
| throws EntityDoesNotExistException { | |||
| for (FeedbackResponseCommentAttributes frc : commentsToSave) { | |||
| try { | |||
| logic.createFeedbackResponseComment(frc); | |||
There was a problem hiding this comment.
Should add a test for this.
xpdavid
added
c.Bug
xpdavid
reviewed
Aug 10, 2018
Yes |
|
Should not have exception now.
|
xpdavid
added
s.FinalReview
damithc
approved these changes
Aug 10, 2018
| * @param expected the expected results for the search query. | ||
| */ | ||
| protected static void verifySearchResults(FeedbackResponseCommentSearchResultBundle actual, | ||
| FeedbackResponseCommentAttributes... expected) { |
There was a problem hiding this comment.
should be 8-space indentation?
xpdavid
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9034