Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9467] Add validation check for "Not Sure" criteria in Contribution question #9487

Merged
merged 1 commit into from
Feb 23, 2019
Merged

[#9467] Add validation check for "Not Sure" criteria in Contribution question #9487

merged 1 commit into from
Feb 23, 2019

Conversation

RonakLakhotia
Copy link
Contributor

@RonakLakhotia RonakLakhotia commented Feb 23, 2019 •
edited
Loading

Part of #9467

Outline of Solution

Added backend validation for v6.

wkurniawan07
wkurniawan07 approved these changes Feb 23, 2019
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkurniawan07 wkurniawan07 merged commit 8cc2964 into TEAMMATES:release Feb 23, 2019
@wkurniawan07 wkurniawan07 self-assigned this Feb 23, 2019
@wkurniawan07 wkurniawan07 added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Feb 23, 2019
@xpdavid xpdavid added this to the V6.16.2 milestone Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@wkurniawan07 wkurniawan07

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V6.16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@RonakLakhotia @wkurniawan07 @xpdavid