Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<docDate> should be in att.datable and lose its bespoke @when #2432

Closed
joeytakeda opened this issue May 8, 2023 · 4 comments · Fixed by #2435
Closed

<docDate> should be in att.datable and lose its bespoke @when #2432

joeytakeda opened this issue May 8, 2023 · 4 comments · Fixed by #2435
Assignees

Comments

@joeytakeda
Copy link
Contributor

In reviewing #2045, @ebeshero, @trishaoconnor, and I were surprised by (and thankful for) @martindholmes ' comment that <docDate> has its own @when and is not part of att.datable. This seems like an error that can be fairly easily resolved.

@JanelleJenstad
Copy link
Contributor

<docDate> also needs a @calendar attribute. It needs to move to the new att.calendarSystem

@JanelleJenstad
Copy link
Contributor

Example: All early modern books have a year (if they have a date at all). If you want to be able to process any data from encoded title pages, you would need a @notBefore and @notAfter date in order to capture the period between March 25 YYYY and March 24 YYYY+1. You also need to be able to capture the @calendar used in the text node (e.g., Julian).

@raffazizzi
Copy link
Contributor

@JanelleJenstad
Copy link
Contributor

Another example:https://digitalcollections.nypl.org/items/510d47e2-c586-a3d9-e040-e00a18064a99
The date one would transcribe and then tag with <date> and @notBefore and @notAfter is 18--

raffazizzi added a commit that referenced this issue May 11, 2023
…bers except date, time, origDate, and docDate. Fixes #2045. Also made docDate member of att.datable. Fixes #2432.
@ebeshero ebeshero added this to the Guidelines 4.7.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants