-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make @source global #536
Comments
Original comment by: @jamescummings |
At Raleigh F2F: Assigning to myself to liaise with HC and see if we can agree at all. ;-) Original comment by: @jamescummings |
There are three types of http://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-att.readFrom.html#tei_att.source http://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-att.source.html#tei_att.source http://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-normalization.html#tei_att.source These are all related in some way (giving the source of something) but are significantly different from each other that making Original comment by: @jamescummings |
This issue was originally assigned to SF user: jcummings |
The basis of my argument for not making |
My own contention is that there is almost nowhere that
|
Does that mean because we made one bad decision (well not one...) we should make another for parallelism? Still not convinced. ;-) |
Tell me where @resp makes sense and @source doesn’t then :-)
|
That's not my point. I'm saying I don't want |
That’s easy: (i.e., I got my revision list from looking at the project commit logs). I do sympathize, but @resp and @source go hand in glove. Now, @cert on is really batshit crazy. I suppose @cert="low" on might mean "I don’t know what the Hell I’m doing; I don’t actually know CSS, so I made something up." I can’t make much sense of it.
|
Whenever someone says something is batshit crazy my devious mind instantly thinks of a case where it might happen. Let's say your source doc no longer exists, and you only have a couple of bad transcriptions by ancient scholars. Those are also damaged. You're trying to infer the original rendition of the text from the inadequate representations made by the transcribers; and in one case they seem in conflict, with one more likely than the other. Surely @resp, @source and @cert? Cheers, Martin Holmes From: Hugh A. Cayless notifications@github.com That's easy: (i.e., I got my revision list from looking at the project commit logs).I do sympathize, but @resp and @source go hand in glove. Now, @cert on is really batshit crazy. I suppose @cert="low" on might mean "I don't know what the Hell I'm doing; I don't actually know CSS, so I made something up." I can't make much sense of it.
Reply to this email directly or view it on GitHubhttps://github.com//issues/536#issuecomment-151669256. |
Council 2015-10-28: A majority agrees to go ahead with adding @source to att.global.responsibility. Set to green. Left with James to implement. |
I'm finally starting to look at implementing this. @lb42: Presumably, this should be waiting until Pure ODD is signed sealed and delivered since I'll need to modify so many spec files? I'll do it in a new branch off that when that has been added to dev. Just to run it by people first what I think I need to do is:
Anything major I'm forgetting there? -James |
|
@raffazizzi: That makes sense. On Council list @lb42 suggests instead renaming the att.source class to att.global.source and change all mentions to be that. This might be less disruptive in terms of breaking things I think I'd still have to do most of the things above (though in some cases renaming to att.global.source). He also confirms this should wait until Pure ODD is finished. |
Adding Status: Blocked until Pure ODD released. |
Actually, no, that is NOT what I suggested. I suggested just adding the existing att.source class to att.global, and leaving the renaming to a later date[1]. After all, it's purely conventional that all subclasses of att.global begin with that string). This would be much less disruptive. [1] by when common sense may have prevailed, and we may wish to deglobalise the wretched thing anyway |
@lb42: Apologies. I misunderstood. However, I'm uncomfortable with breaking with convention for our class naming (that way anarchy lies). But even if the class name was the same wouldn't we still have to delete reference to it everywhere since those elements already are members of att.global and so would get it twice? Once something has be globalised, and released to the public, I think it is bad form to deglobalise it without using proper deprecation, etc. This is one of those reasons I'm always so dead set against making thing global, much more dangerous to change or remove later IMHO. |
Ah, yes. Bother. Thought it was too good to be true. |
Ignoring the issue of whether it ought to be global or not, I don't think it's a good idea to create a global class which is uniquely excluded from the naming convention that helps people understand what's global and what isn't. |
James — |
Temporarily removing Status:Go to make sure I've got this right: I'll do as I outlined above but:
Just double checking before returning to status:go. Right? (will assume no comments is agreement, but would be good to get some confirmation since this is a att.global.* change) |
Council subgroup thinks this is a GREEN, and work on a branch. |
I'll go ahead and implement then. |
Rather confused by the arguments above that adding
Is the alternative that a feature request should be opened for every element on which we need |
Making I don't really have an opinion on |
To be clear, I'm not really arguing for reversing that decision (I didn't have a strong opinion on it either way to start with, but I tend to agree with you that there's nothing wrong with global attributes or classes), rather I was pointing out the irrationality of using resentment of the globality of I think I may have trouble making clear the complete parallelism and interdependence of If
You might also want to say either or both of:
Even if, as is clearly the case, you might not always want to be able to make all three of these statements, the fact that the two attributes belong together—conceptually as well as technically—is unchanged. They might need to be used, separately or together, in almost any context. (Most of us will never use |
I'm not quite sure how I've sidestepped anything. I was suggesting that I was going to do this by creating att.global.source rather than putting it into att.global.responsibility -- both of these are global classes. The issue is agreed and Council says I should go ahead with this. (I've just been busy with other things but will do so before next release.) I was just double-checking the steps that should be taken since I'd rather not muck it up. (Hence Council's suggestion to work in a branch.) The issue here is now only waiting on my implementation of it to close, unless you have a variation on how I should be implementing it? I do disagree that there isn't anything wrong with global attributes (or classes) -- because these are global and thus appear anywhere I think there should always be a higher bar to accepting them because more and more global attributes seems to ben an entropic direction of travel. (We then get asked, why not make all attributes global, all elements allowed everywhere, etc.) I think as elected representatives of the community we should definitely play devil's advocate any time anyone suggests additional elements or attributes that can appear anywhere. This doesn't mean I'm against them, just that we should do our due diligence in ensure the argument for them is made. However, I don't really think individual issues is the right place to discuss this. (And I probably owe you a beer in any case....) In this case, while I personally have my reservations, I'm instructed to add it, and so will do so. (Soon'ish, I promise.) |
Ah, okay! I'm delighted then to say that I misunderstood the status of this ticket (I asked a council member—who shall remain unnamed—why I still don't understand why Thanks! |
Should all be dealt with now. |
Given that att.responsibility is becoming global (see [feature-requests:#443]),
@source
should also become global, since they belong together. See also [feature-requests:#465].Original comment by: @hcayless
The text was updated successfully, but these errors were encountered: