-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding where to new att.locatable to address #1769 #1958
Conversation
Okay, we're really passing build tests now. Let's take a look and see if this is what we want to add to the Guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the bibliography shows a lot of whitespace changes. Is it somehow possible to reset these and only add the needed changes?
P5/Source/Specs/move.xml
Outdated
@@ -173,7 +104,7 @@ $Id$ | |||
</castList> | |||
</performance> | |||
<!-- ... --> | |||
<stage type="entrance"><move who="#bellaf" type="enter" where="L" perf="#perf1"/> Enter | |||
<stage type="entrance"><move who="#bellaf" type="enter" where="#L" perf="#perf1"/> Enter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need an example for resolving the where="#L"
as all other targets of references ("#bellaf" and "#perf1") are provided.
…n in Guidelines re #1769
@peterstadler @martindholmes @martinascholger @TEITechnicalCouncil Thanks for your help with this PR! I've made some changes as we discussed to expand the examples, so we now have some lists of stage movements for |
Edited the above to separate this part out: If we decide this is okay to merge into dev, can I get some help with figuring out how to do something like a deprecation of the old way of doing things, like we discussed in our meeting? @sydb : I'm trying to remember how we do this. |
a9c01b0
to
27cd1c8
Compare
Just an update on this branch--I think we resolved the requested changes now, but there's an outstanding issue (not on the reviews I think?) about how we talk to people about their use of the new datatype on |
VF2F decision: We are thinking of better ways to handle the expression of stage movement, and think |
I've moved
@where
to a newatt.locatable
and I'm hoping we can look at / improve my new explanation of it. I'm also hoping we can add some translations to other languages here.