Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gender element, attributes, modifications of sex and gender for #2189 and #2190 #2299

Merged
merged 40 commits into from
Sep 6, 2022

Conversation

ebeshero
Copy link
Member

No description provided.

7</biblScope>, <biblScope unit="pp">p.121</biblScope>.</bibl>
Sorcerer's Stone</title>, <pubPlace>New York</pubPlace>: <publisher>Scholastic, Inc.</publisher> (<date>1999</date>), <biblScope unit="chap">chapter
7</biblScope>, <biblScope unit="pp">p. 121</biblScope>.</bibl>
<bibl xml:id="rubin-NDPERSEpc"><author>Rubin, Gayle</author>, <title level="a">The Traffic in Women:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this work be cited in the bibliography related to the examples, or isn‘t it better within the list of “Works Cited Elsewhere in the Text of these Guidelines”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HelenaSabel Oh, thank you! I'll move it to the appropriate list.

Copy link
Member

@HelenaSabel HelenaSabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments that could be addressed before merging, but other than that the PR looks great!

or project-internal taxonomies for consistency, and should not be used where that is
inappropriate or unhelpful. The content of the element may be used to describe
the intended concept in more detail, using plain text. </p>
<remarks versionDate="2022-05-03" xml:lang="en">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the <exemplum> in French could have been kept just by replacing the “2” with a “F”. For the one in Taiwanese Mandarin, I think the same change could be made (just like you did with in the case of the examples of <person>).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm restoring those exempla.

Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall excellent.
One serious error and several suggested wording tweaks, and I think it is ready to go.

@@ -1035,8 +1034,7 @@ target="#CONA"/>). The tag -->The
<!-- socecstatus has its own @code and @scheme attributes which need
exemplifying here too? -->
</p>
<p>The meanings of concepts such as sex, nationality, or age are highly culturally-dependent, and the encoder should take
particular care to be explicit about any assumptions underlying their usage of them. For example, when recording
<p>Encoders should take particular care to be explicit about culturally determined concepts such as sex/gender system, nationality, ethnicity, or age that influence their markup. For example, when recording
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a “sex/gender system”? Is it a culturally determined concept? Either way I hate using a slash like that. I think I would prefer to just see “sex, gender, nationality, ethnicity, or age”.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is in reference to Gayle Rubin's influential theory of "sex/gender systems". Gayle Rubin, "The Traffic in Women: Notes on the ‘Political Economy’ of Sex,” Toward an Anthropology of Women, ed. Rayna R. Reiter (New York: Monthly Review Press, 1975) 157-210.
Perhaps there should be a reference here so that it's clear that we are borrowing a term

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified the wording a little and added a note with reference to Gayle Rubin.

<ptr target="http://standards.iso.org/ittf/PubliclyAvailableStandards/c036266_ISO_IEC_5218_2004(E_F).zip"/> (in which
<val>0</val> indicates unknown; <val>1</val> indicates male; <val>2</val> indicates female; and <val>9</val> indicates
not applicable, although the ISO standard is widely considered inadequate). <egXML
<p>The <gi>sex</gi> and <gi>gender</gi> elements carry a <att>value</att> attribute to give values from a project-internal taxonomy, or an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m thinking The <gi>sex</gi> and <gi>gender</gi> elements each carry a <att>value</att> attribute …, i.e. inserting “each” so the conjunction on the L can be properly treated as singular on the R.

Copy link
Member Author

@ebeshero ebeshero Aug 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

<desc versionDate="2022-05-03" xml:lang="en">supplies a coded value for gender identity</desc>
<datatype minOccurs="1" maxOccurs="unbounded"><dataRef key="teidata.gender"/></datatype>
<remarks versionDate="2022-05-03" xml:lang="en">
<p>Values for this attribute may be locally defined by a project or according to an external standard.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Values for this attribute may be taken from an external standard or locally defined by a project”.
Or the wording in comment below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the syntax isn't parallel--revise.

Copy link
Member Author

@ebeshero ebeshero Aug 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying this: "Values for this attribute may be locally defined by a project, or they may refer to an external standard."

cf. CETH's <title>Recommendations for Inclusive Data Collection of Trans People</title>
<ptr target="http://transhealth.ucsf.edu/trans?page=lib-data-collection"/>.</p>
<remarks versionDate="2022-05-18" xml:lang="en">
<p>Values for this attribute may be locally defined by a project or according to an external standard.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Values for this attribute may be locally defined by a project, or may refer to an external standard.”
Or the wording in comment above.

<desc versionDate="2022-05-18" xml:lang="en">specifies the gender of the persona.</desc>
<datatype minOccurs="1" maxOccurs="unbounded"><dataRef key="teidata.gender"/></datatype>
<remarks versionDate="2022-05-18" xml:lang="en">
<p>Values for this attribute may be locally defined by a project or according to an external standard.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous 2 comments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this wording instead--throughout.

@@ -8,15 +8,15 @@ $Id$
-->
<?xml-model href="https://jenkins.tei-c.org/job/TEIP5-dev/lastSuccessfulBuild/artifact/P5/release/xml/tei/odd/p5.nvdl" type="application/xml" schematypens="http://purl.oclc.org/dsdl/nvdl/ns/structure/1.0"?>
<elementSpec xmlns="http://www.tei-c.org/ns/1.0" module="namesdates" ident="sex">
<gloss xml:lang="en" versionDate="2009-03-19">sex</gloss>
<gloss xml:lang="en" versionDate="2022-05-10">sex</gloss>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not since there is no chance to the gloss. Reverted.

<dataRef key="teidata.enumerated"/>
</content>
<remarks versionDate="2022-05-03" xml:lang="en">
<p>Values for attributes using this datatype may be locally defined by a project or according
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous on this phrasing.

<remarks versionDate="2022-05-03" xml:lang="en">
<p>Values for attributes using this datatype may be locally defined by a project or according
to an external standard.</p>
<p>Values for this datatype may not be used to encode morphological gender (cf. <gi>gen</gi>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change “may” to “should”.

<dataRef key="teidata.enumerated"/>
</content>
<remarks versionDate="2022-05-03" xml:lang="en">
<p>Values for attributes using this datatype may be locally defined by a project or according
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ibid.

@@ -1370,6 +1371,7 @@ entities in the XML DTD fragments.--></p>
values). In this latter case, the datatype will not be <ident type="datatype">teidata.enumerated</ident>, but an explicit list of the possible values.</p>
<specGrp xmlns:rng="http://relaxng.org/ns/structure/1.0" xml:id="DTYPES-4" n="Coded value datatypes">
<xi:include href="../../Specs/teidata.word.xml"/>
<xi:include href="../../Specs/teidata.gender.xml"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS AN ERROR
The definitions of teidata.gender and teidata.sex are now teidata.enumerated; therefore they need to be included after teidata.enumerated is. (Lest DTDs break.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in 3dc6914

will obviously change over time, hair colour for example, none, in principle—not even sex—is immutable.</p>

<p><soCalled>States</soCalled> include, for example, marital status, place of residence and position or occupation. Such
or action and can be either physical, such as hair and eye colour, or cultural, such as ethnicity, caste, or faith.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a semicolon between "colour; or cultural"

@ebeshero
Copy link
Member Author

ebeshero commented Aug 28, 2022

@sydb We've made several changes in response to your review and we may now be ready to merge this in to dev (you're the one we assigned for this!)
NOTE: I've added some short but significant revisions to our discussion of characteristics/traits in the ND chapter while working on the PR this weekend, mainly to revise some strange things and provide a little more commentary specific the challenges we face as text encoders of documents from times and places not our own. I hope it's all good!

Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty close to ready to merge.

<macroRef key="macro.phraseSeq"/>
</content>
<attList>
<attDef ident="type" usage="opt" mode="change">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit confused — what is the point of lines 26–30? Since this is a member of att.typed it already has a @type attribute that is teidata.enumerated without a value list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed this is an error due to using the specs of <sex> as a template. In <sex> there was the sample values “explicit” and “implicit”, and indeed, if we are not going to suggest any values for @type, this should be deleted.

Copy link
Member Author

@ebeshero ebeshero Sep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed with 1bd0f6a

<remarks versionDate="2022-08-27" xml:lang="en">
<p>Values for attributes using this datatype may be defined locally by a project, or they may refer to an external standard.</p>
<p>Values for this datatype should not be used to encode morphological gender (cf. <gi>gen</gi>,
<att>msd</att> as defined in att.linguistic, and <ptr target="#DITPFO"/>).</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

<ident type="class">att.linguistic</ident>

(As much as I do not like that encoding (because I think it is a name, not an identifier), it is what we use.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 1bd0f6a

Copy link
Member

@martinascholger martinascholger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I agree with @sydb's comments.

and skull measurements, is now recognized as a social construct.</p>
interpreted based on the social hierarchies of a time and place. Also the division of humanity into different <soCalled>races</soCalled>,
formalized in the nineteenth century to organize a hierarchy of humanity on the basis of physical characteristics such as skin colour, hair type,
and skull measurements, is now recognized as a colonial social construct. When that construct defined individuals' identities beyond their volition,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there should be a bibiographical reference

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinascholger There is so much we could cite, and it tends to be concentrated on specific colonized parts of the world. Looking for something quite general to cite, I wonder if this reference would work for the audience of the Guidelines? https://www.cambridge.org/core/books/abs/reproduction/colonialism-and-the-emergence-of-racial-theories/122DB95AC72DCB6CCDF6C7E034EFEC72

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinascholger I've added a citation now with this commit: d963460

Thanks for the suggestion! How does that look to you?

Copy link
Member

@HelenaSabel HelenaSabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to delete the definition of @type in both <gender> and <sex> since we no longer suggest sample values.

Comment on lines 26 to 30
<attDef ident="type" usage="opt" mode="change">
<datatype>
<dataRef key="teidata.enumerated"/>
</datatype>
</attDef>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<attDef ident="type" usage="opt" mode="change">
<datatype>
<dataRef key="teidata.enumerated"/>
</datatype>
</attDef>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 1bd0f6a

@@ -32,74 +32,55 @@ $Id$
<datatype>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code from lines 31-35 should be deleted if no sample values are suggested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 1bd0f6a

@ebeshero
Copy link
Member Author

ebeshero commented Sep 5, 2022

@martinascholger @sydb I think we're now up-to-date with responding to all the revision requests. Are we ready to merge this branch to dev?

@sydb sydb merged commit a581874 into dev Sep 6, 2022
@sydb
Copy link
Member

sydb commented Sep 6, 2022

I am not remotely convinced this is perfect. I reasonably convinced it is good enough to be part of the Guidelines proper, and be tweaked in dev as needed.

@sydb
Copy link
Member

sydb commented Sep 6, 2022

BTW —

  • Passed all tests in my local Docker environment.
  • I used a squash-and-merge, so we may not want to delete the branch for a bit.

@sydb sydb deleted the gender branch September 11, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants