Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing <sch:rule> elements #2540

Merged
merged 5 commits into from
May 17, 2024
Merged

Conversation

sydb
Copy link
Member

@sydb sydb commented Mar 19, 2024

Title says it all.

<elementSpec ident="list" mode="change">
<attList>
<attDef ident="type" mode="change">
<constraintSpec mode="add" ident="a1" scheme="schematron">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

European subgroup wonders why the constraintSpec is within the attList/attDef and not a child of elementSpec

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have answer, but not a good answer.
The difference was that declaring the constraint specification within the attribute definition (as opposed to as a direct child of the element specification) meant that it was fired only for <list> elements that actually had a @type attribute, regardless of that attribute’s value. That has now been duplicated by using a @context of "tei:list/@type".
What I cannot explain is why anyone thought it was import to fire this test only when a <list> has a @type. Seems nonsensical to me. (Maybe the author wanted to test that it indeed only fired when there was a @type?)

@martinascholger
Copy link
Member

@sydb and @martinascholger will resolve the conflicts and merge it

 * P5/Exemplars/tei_enrich.odd
 * P5/Exemplars/tei_simplePrint.odd
 * P5/Test/testmeta2010.odd
 * P5/Utilities/TEI-to-tei_customization.xslt
@raffazizzi raffazizzi merged commit aa14666 into dev May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants