Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Booking Model Review #47

Merged
merged 45 commits into from
Mar 11, 2021
Merged

Booking Model Review #47

merged 45 commits into from
Mar 11, 2021

Conversation

chx2
Copy link
Contributor

@chx2 chx2 commented Mar 6, 2021 •
edited
Loading

Working on updated Models/Migrations/Factories based on @sl0wik 's updated logic structure https://whimsical.com/booking-VrUF3bVpqu7JEjKy9tmr3Q

This also includes merged changes from #52

@chx2 chx2 self-assigned this Mar 6, 2021
chx2
chx2 commented Mar 6, 2021
View reviewed changes
src/Models/Rate.php Outdated Show resolved Hide resolved
@chx2
Copy link
Contributor Author

chx2 commented Mar 6, 2021

@sl0wik should I worry about policies and nova resources based on the notion.so task for now?

@sl0wik
Copy link
Contributor

sl0wik commented Mar 7, 2021

In ref to policies - you can keep everything allowed for now (but if you got new resource good to create policy)

wolfrednicolas and others added 17 commits March 8, 2021 18:00
@wolfrednicolas
remove slot config array and service_class use in slot classes
c3c80b9
@wolfrednicolas
remove SlotFactory
b9e89fe
@wolfrednicolas
remove Slot Migration
1814073
@wolfrednicolas
remove Slot from the BookingServiceProvider
72e79c7
@wolfrednicolas
remove Slot model
5bbb658
@wolfrednicolas
change the namespaces in the filterClassList array in the booking model
a55e59b
@wolfrednicolas
remove FutureSlots from nova filters
62987fd
@wolfrednicolas
remove SlotDayFilter
3d229a6
@wolfrednicolas
remove Nova Slot model
b4446bd
@wolfrednicolas
remove SlotPolicy
f420d01
@wolfrednicolas
remove slot from the novaPackageServiceProvider
1ba0d7b
@chx2
Rate Category #42
150f852
@chx2
Update booking category references #40
8b0fa93
@wolfrednicolas
Merge branch 'wolfrednicolas/feature/remove-slot-model-and-dependenci…
46d9aac 
…es' into chx2/feature/booking-model-review
@wolfrednicolas
Merge branch 'chx2/feature/booking-model-review' of github.com:tipoff…
b0f7649 
…/bookings into chx2/feature/booking-model-review
@chx2
Use RateCategory in Rate factory #42
a004228
@chx2
Merge remote-tracking branch 'origin/chx2/feature/booking-model-revie…
30df917 
…w' into chx2/feature/booking-model-review
chx2
chx2 commented Mar 9, 2021
View reviewed changes
src/Models/Booking.php Outdated Show resolved Hide resolved
chx2
chx2 commented Mar 9, 2021
View reviewed changes
src/Models/Booking.php Outdated Show resolved Hide resolved
@chx2
Copy link
Contributor Author

chx2 commented Mar 9, 2021

Besides pending resolving comments and determining @sl0wik 's intentions in #49, I'm going to transition this into review. Will keep DNM tag until all comments are resolved.

@chx2 chx2 marked this pull request as ready for review March 9, 2021 01:58
@chx2 chx2 changed the title Booking Model Review WIP: Booking Model Review Mar 9, 2021
@chx2 chx2 changed the title WIP: Booking Model Review Booking Model Review Mar 9, 2021
@chx2
Copy link
Contributor Author

chx2 commented Mar 10, 2021

Besides implementation of interfaces from TIPOFF/support#85, @sl0wik are we good to go otherwise?

This was referenced Mar 10, 2021
Merged
Merged
@drewroberts
Copy link
Member

@chx2 & @sl0wik Check out the changes we're making to the Status package here:

@chx2 chx2 mentioned this pull request Mar 10, 2021
Merged
drewroberts
drewroberts approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU ALL! 🚀

@drewroberts drewroberts merged commit 9c9fc43 into main Mar 11, 2021
@drewroberts drewroberts deleted the chx2/feature/booking-model-review branch March 11, 2021 15:50
@chx2 chx2 mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0wik sl0wik sl0wik left review comments

@pdbreen pdbreen pdbreen left review comments

@drewroberts drewroberts drewroberts approved these changes

Assignees

@chx2 chx2

Labels
DO NOT MERGE YET
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chx2 @sl0wik @wolfrednicolas @drewroberts @pdbreen