Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Locales #44

Closed
drewroberts opened this issue Mar 6, 2021 · 4 comments · Fixed by #56
Closed

Search Locales #44

drewroberts opened this issue Mar 6, 2021 · 4 comments · Fixed by #56
Assignees
Labels
model description Description of a model Perpetual Never ending issues

Comments

@drewroberts
Copy link
Member

For the search Rankings (#18) we need to create a model for Search Locales and add a relationship to them. More info in the SerpApi documentation:

I don't want to get too granular with these. For this package, I just want to use the United States as the default Search Locale and then create one for all 210 of the DMA Regions (TIPOFF/addresses#42) in the United States.

drewroberts added a commit that referenced this issue Mar 12, 2021
@drewroberts drewroberts reopened this Mar 12, 2021
@drewroberts drewroberts added model description Description of a model Perpetual Never ending issues labels Mar 12, 2021
@drewroberts
Copy link
Member Author

We'll need a relationship between Search Locales and Keywords (#17) so the command to pull Rankings knows which Locale to use. I know Moz allows multiple Search Locales per Keyword, so let's make this a many-to-many relationship with a pivot table.

@drewroberts drewroberts self-assigned this Mar 12, 2021
@arwaawan3
Copy link
Contributor

@drewroberts I'm creating the pivot table for another SEO task. Do we need a nova resource for Search Locales?

@drewroberts
Copy link
Member Author

Yes, thank you.

@joshtorres joshtorres linked a pull request Apr 4, 2021 that will close this issue
@drewroberts drewroberts removed a link to a pull request Apr 12, 2021
@joshtorres
Copy link
Member

I believe this is finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model description Description of a model Perpetual Never ending issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants