Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Locales #44 [TGER-96] #56

Merged
merged 9 commits into from
Mar 12, 2021
Merged

Search Locales #44 [TGER-96] #56

merged 9 commits into from
Mar 12, 2021

Conversation

devjk1
Copy link
Contributor

@devjk1 devjk1 commented Mar 12, 2021 •
edited
Loading

closes #44
#2

  • add Model SearchLocale
  • add Migration for SearchLocales
  • add relationship in Model Ranking belongsTo SearchLocale
  • add SearchLocale FK to Migration Ranking
  • add SearchLocale FK to Migration Ranking Index
  • create Factory for SearchLocale
  • fix Factory for Ranking

Note:

  • Migration SearchLocale, two ids (ours / API id)
  • https://serpapi.com/locations-api
  • not sure if the API ID is "1 to 1" with 'google_id'
  • Col 'reach' max ~4 billion
  • did not add Nova resource SearchLocale

@devjk1 devjk1 requested a review from joshtorres March 12, 2021 20:02
@devjk1 devjk1 changed the title Omnia/feature/44 search locales Omnia [TGER-96] 44 search locales Mar 12, 2021
@drewroberts drewroberts changed the title Omnia [TGER-96] 44 search locales Search Locales #44 [TGER-96] Mar 12, 2021
@drewroberts drewroberts self-requested a review March 12, 2021 20:19
drewroberts
drewroberts approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks! 🎳

@drewroberts drewroberts merged commit f128c2c into main Mar 12, 2021
@drewroberts drewroberts deleted the omnia/feature/44_search_locales branch March 12, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

@joshtorres joshtorres Awaiting requested review from joshtorres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search Locales
2 participants
@devjk1 @drewroberts