Skip to content

Conversation

alexanderlinne
Copy link
Collaborator

@alexanderlinne alexanderlinne commented Sep 26, 2025

  • Refactor Object Predicates and Conditions to only have one implementation using IObjectProvider (except for AttributeWithArguments which will be refactored in a separate PR)
  • Add a FormatDescription to IObjectProvider which takes a description prefix for zero, one or multiple elements and returns a string-description for the IObjectProvider with the appropriate prefix
  • Use string.Join where possible
  • Add missing HaveName variants

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
@alexanderlinne alexanderlinne force-pushed the refactor/object-syntax-elements branch from e1c3fe8 to b31629b Compare September 26, 2025 12:41
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 96.29630% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.84%. Comparing base (659e039) to head (ad21b7b).

Files with missing lines Patch % Lines
...hUnitNET/Domain/Extensions/EnumerableExtensions.cs 0.00% 8 Missing ⚠️
ArchUnitNET/Domain/ObjectProvider.cs 50.00% 7 Missing ⚠️
ArchUnitNET/Domain/SystemTypeObjectProvider.cs 46.15% 7 Missing ⚠️
ArchUnitNET/Fluent/BasicObjectProvider.cs 0.00% 3 Missing ⚠️
ArchUnitNET/Fluent/Slices/GivenSlices.cs 0.00% 3 Missing ⚠️
ArchUnitNET/Domain/Extensions/NamingExtensions.cs 93.93% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   77.61%   74.84%   -2.77%     
==========================================
  Files         258      257       -1     
  Lines       19226    17224    -2002     
  Branches     1606     1574      -32     
==========================================
- Hits        14923    12892    -2031     
- Misses       3848     3876      +28     
- Partials      455      456       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
@alexanderlinne alexanderlinne merged commit 8da498a into main Sep 26, 2025
9 checks passed
@alexanderlinne alexanderlinne deleted the refactor/object-syntax-elements branch September 26, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants