Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE fix #46

Merged
merged 7 commits into from
Feb 16, 2023
Merged

QE fix #46

merged 7 commits into from
Feb 16, 2023

Conversation

alberto-carta
Copy link
Collaborator

@alberto-carta alberto-carta commented Feb 13, 2023

  1. Modified energy calculation to be coherent with vasp:

First iteration:

  • energy is read from the seedname.scf.out file

Subsequent iterations:

  • Band energy is now read from the seedname.mod_scf.out file, and subtracted from the total energy.
  • The correct band energy is read from the seedname.nscf.out file and added to the total energy
  1. Manual compilation of the openmpi library to ensure PMI compatibility. This makes multi-node calculations viable on cray systems

@alberto-carta alberto-carta merged commit c3aaf12 into unstable Feb 16, 2023
the-hampel pushed a commit that referenced this pull request May 29, 2023
PR #48 and #46

The occupation correction GAMMA in Vasp is now recalculated between subsequent steps. Also reorganized csc_flow to reflect the actual process better and make it more readable. Other changes:

- Introduced parameter dft/n_iter_first: the number of DFT iterations in the first round of charge corrections
- Removed parameter general/oneshot_postproc_gamma_file
- Added docker file with Vasp 5 to avoid problems with the current Vasp 6 setup for CSC
- Moved the more technical functions from csc_flow into the dft_managers
- Changed the way QE restarts a calculation because before it ended up diverging frequently when restarting
- Made w90 the default for parameter dft/projector_type: this option is actually supported by both DFT codes
- solid_dmft raises an error when trying to restart Vasp CSC because it's not cleanly implemented

These changes are tested with Vasp on SrVO3 with Wannier90 and PLO projectors and on LuNiO3 with PLO projectors as well as in QE with Wannier90 on LuNiO3.

Also fixes total energy with QE as described in PR #46
@alberto-carta alberto-carta deleted the QE_fix branch September 27, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant