[BUGFIX] Return text node if pcre fails to parse (#453) #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrodala
suggested changes
May 15, 2019
|
It actually also depends/should be merged together with another patch that @NamelessCoder will create where he is fixing the namespacing issue PR-352 I believe - so just let it cook for a couple of days ;-) |
thomashohn
changed the title
NamelessCoder
approved these changes
Jul 18, 2019
NamelessCoder
changed the title
NamelessCoder
changed the title
mbrodala
reviewed
Jul 18, 2019
mbrodala
approved these changes
Jul 18, 2019
|
Thanks for the change. |
NamelessCoder
pushed a commit
that referenced
this pull request
Sep 8, 2019
NamelessCoder
pushed a commit
that referenced
this pull request
Sep 8, 2019
CDRO
pushed a commit
to CDRO/Fluid
that referenced
this pull request
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return text node with the full text instead instead of dying.
When PCRE is unable to parse a chunk of Fluid code, a fatal PHP
error will be encountered. The cause is platform- and version-
dependent and cannot be reproduced with a unit test (at least
not without further refactoring in a class that's being already
in the process of being rewritten).