[TASK] Avoid and deprecate ViewHelperCompiler #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ViewHelperCompiler helper class has been introduced a while ago and shrinked over time again. It consists of one method with an sprintf() and two constants nowadays. It is used in the two traits CompileWithRenderStatic and CompileWithContentArgumentAndRenderStatic. To simplify the code a bit, the code of ViewHelperCompiler is now inlined to the two traits, which makes them easier to read and understand. ViewHelperCompiler is marked @deprecated, neither Flow nor TYPO3 use that class, so impact should be rather low.
sbuerk
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ViewHelperCompiler helper class has been
introduced a while ago and shrinked over
time again. It consists of one method with
an sprintf() and two constants nowadays.
It is used in the two traits
CompileWithRenderStatic and
CompileWithContentArgumentAndRenderStatic.
To simplify the code a bit, the code of
ViewHelperCompiler is now inlined to the
two traits, which makes them easier to
read and understand. ViewHelperCompiler
is marked @deprecated, neither Flow nor
TYPO3 use that class, so impact should be
rather low.