[TASK] Simplify array representation in compiled templates #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeConverter->convertArrayNode() is changed to render more dense and easier readable PHP code for arrays. Also, NodeConverter is marked @internal since it is pretty much directly bound to the node based syntax tree created by TemplateParser, and deep wired to TemplateCompiler. Changing NodeConverter for anything important would mean changing TemplateParser, TemplateCompiler and probably nodes as well. The most important consumers Flow and TYPO3 don't do that.
sbuerk
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeConverter->convertArrayNode() is changed to
render more dense and easier readable PHP code
for arrays.
Also, NodeConverter is marked @internal since
it is pretty much directly bound to the node
based syntax tree created by TemplateParser,
and deep wired to TemplateCompiler.
Changing NodeConverter for anything important
would mean changing TemplateParser, TemplateCompiler and probably nodes as well. The most important
consumers Flow and TYPO3 don't do that.