-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Eliminate side-effects from ForViewHelper #820
Conversation
ba0404f
to
d635fda
Compare
Just noticed that this would break the following hack/work-around: <f:for each="{items}" as="item">
<f:variable name="lastItem" value="{item}" />
</f:for> Maybe we need some kind of merge logic here? |
d635fda
to
beac964
Compare
The new version of this patch should resolve this problem. |
I think that there is still an edge case here: <f:variable name="lastItem" value="fallback" />
<f:for each="{items}" as="item">
<f:variable name="lastItem" value="{item}" />
</f:for> In this case, Edit: Checked it with tests, this is in fact NOT the case, because only variables defined by |
c7873f2
to
aac1ef4
Compare
The previous implementation overwrote template variables with the same name as the specified ViewHelper parameters "as", "key", or "iteration". With the new implementation, the variable state before the ViewHelper call gets restored once the ViewHelper call is completed.
aac1ef4
to
36fcb71
Compare
The previous implementation overwrote template variables with the same name as the specified ViewHelper parameters "as", "key", or "iteration". With the new implementation, the variable state before the ViewHelper call gets restored once the ViewHelper call is completed.