[BUGFIX] Throw array conversion exception in AbstractNode->castToString()
#827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing()` `AbstractNode->castToString()` already checked for objects which could not converted to a string representation due to missing `__toString()` method. It's possible that the value could be an array, which per nature is not really convertable to a string anyway. Older php versions simply converted it to an `Array` string along with a notices, which has been raised to a warning in newer PHP versions. There is no way to properly convert an array, therefore the PHP warning should always lead to an parser exception like for object not convertable. This change now checks explicitly for an array and throws a corresponding `TYPO3Fluid\Fluid\Core\Parser\Exception` with a meaningfull message. Test is extended to cover this case. Resolves: #826
s2b
approved these changes
Nov 20, 2023
|
I agree that a proper exception should be thrown for this. However, this might break existing templates where PHP warnings are suppressed. Not sure if this is a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractNode->castToString()already checked for objects which could notconverted to a string representation due to missing
__toString()method.It's possible that the value could be an array, which per nature is not
really convertable to a string anyway. Older php versions simply converted
it to an
Arraystring along with a notices, which has been raised to awarning in newer PHP versions.
There is no way to properly convert an array, therefore the PHP warning
should always lead to an parser exception like for object not convertable.
This change now checks explicitly for an array and throws a corresponding
TYPO3Fluid\Fluid\Core\Parser\Exceptionwith a meaningfull message.Test is extended to cover this case.
Resolves: #826