[BUGFIX] Fix memory overhead of getScopedCopy() #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of getScopedCopy() in the new ScopedVariableProvider copied both local and global variables. This is not necessary because all variables (except for settings) are provided explicitly and thus existing data in the data structure is irrelevant. The new implementation reduces that unnecessary overhead by returning a StandardVariableProvider instead.
s2b
force-pushed
the
bugfix/scopedCopy
branch
from
fe987f3
to
ffce922
Compare
lolli42
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of getScopedCopy() in the new ScopedVariableProvider copied both local and global variables. This is not necessary because all variables (except for settings) are provided explicitly and thus existing data in the data structure is irrelevant.
The new implementation reduces that unnecessary overhead by returning a StandardVariableProvider instead.