[BUGFIX] Choose global/local variable based on primary identifier #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fier With the previous implementation of ScopedVariableProvider, variables that contained arrays or object structures could behave incorrectly in a scoped context. When accessing a object path in a fluid template (e. g. myVar.subKey), the value of that "sub variable" was considered for the decision which variable (global or local) should be used. This behavior is incorrect, only the "primary" variable name should determine if a local variable is set or not (and should fall back to a global variable). This would mean that a non-existing sub value in a local variable would trigger a fallback to the global variable. This change restores the correct behavior: Only the "primary" variable name is checked initially. If the variable exists in the local variables, those will be used, even if the requested sub value doesn't exist there. Only if the "primary" variable name doesn't exist in local variables, global variables will be used instead. Resolves #848
s2b
changed the title
sbuerk
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous implementation of ScopedVariableProvider, variables that contained arrays or object structures could behave incorrectly in a scoped context. When accessing a object path in a fluid template (e. g. myVar.subKey), the value of that "sub variable" was considered for the decision which variable (global or local) should be used.
This behavior is incorrect, only the "primary" variable name should determine if a local variable is set or not (and should fall back to a global variable). This would mean that a non-existing sub value in a local variable would trigger a fallback to the global variable.
This change restores the correct behavior: Only the "primary" variable name is checked initially. If the variable exists in the local variables, those will be used, even if the requested sub value doesn't exist there. Only if the "primary" variable name doesn't exist in local variables, global variables will be used instead.
Resolves #848