[TASK] Prepare fluid binary to support multiple commands #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fluid binary currently only supports one command: The execution of fluid code, supplied by various sources, like a file, interactively or via socket. To be able to add more features in the future, a command parameter has been introduced to differentiate various sub-commands. The existing functionality is now available as a sub-command by executing "bin/fluid run". However, the "run" command is defined as default command in this first step, which means that the previous syntax still works and that this change should be non-breaking. Since ConsoleRunner has been defined as @internal, it has been marked as final, also the visibility of methods, variables and constants has been set to private to reduce/clarify the API of the class.
lolli42
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fluid binary currently only supports one command: The execution of fluid code, supplied by various sources, like a file, interactively or via socket. To be able to add more features in the future, a command parameter has been introduced to differentiate various sub-commands.
The existing functionality is now available as a sub-command by executing "bin/fluid run". However, the "run" command is defined as default command in this first step, which means that the previous syntax still works and that this change should be non-breaking.
Since ConsoleRunner has been defined as @internal, it has been marked as final, also the visibility of methods, variables and constants has been set to private to reduce/clarify the API of the class.