[FEATURE] Support for boolean tag attributes #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2b
force-pushed
the
feature/booleanTagAttributes
branch
3 times, most recently
from
888f67a
to
7ec5c3b
Compare
s2b
force-pushed
the
feature/booleanTagAttributes
branch
9 times, most recently
from
540e376
to
7a03af5
Compare
s2b
changed the title
|
This PR is based on #949 |
s2b
force-pushed
the
feature/booleanTagAttributes
branch
2 times, most recently
from
29750a7
to
0a5bbc1
Compare
|
Test run with TYPO3 core: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85568 |
s2b
force-pushed
the
feature/booleanTagAttributes
branch
from
0a5bbc1
to
f3c2ffe
Compare
TagBasedViewHelpers now have proper support for boolean attributes.
Before this change, it was very cumbersome to generate these with Fluid,
now it's implemented similar to popular JavaScript frameworks:
```
<my:viewhelper async="{true}" />
Result: <tag async="async" />
<my:viewhelper async="{false}" />
Result: <tag />
```
This can also be used in combination with variable casting:
```
<my:viewhelper async="{myString as boolean}" />
```
For compatibility reasons empty strings still lead to the attribute
being omitted from the tag. This might change in the future, however
we don't want to break templates now. ViewHelpers can define
an argument manually and implement the desired behavior in the
render method (this is how the ImageViewHelper in TYPO3 deals with
empty `alt` attributes).
s2b
force-pushed
the
feature/booleanTagAttributes
branch
from
f3c2ffe
to
3b54553
Compare
lolli42
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagBasedViewHelpers now have proper support for boolean attributes.
Before this change, it was very cumbersome to generate these with Fluid,
now it's implemented similar to popular JavaScript frameworks:
This can also be used in combination with variable casting:
For compatibility reasons empty strings still lead to the attribute
being omitted from the tag. This might change in the future, however
we don't want to break templates now. ViewHelpers can define
an argument manually and implement the desired behavior in the
render method (this is how the ImageViewHelper in TYPO3 deals with
empty
altattributes).