[TASK] Type hint arguments in ViewInterface #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper type hints to the two arguments in ViewInterface->assign(). This is not breaking since existing implementations can still accept "more" by not setting these arguments - method arguments of subtypes are contravariant. This will be backported to 2.14.
s2b
approved these changes
Jul 23, 2024
lolli42
added a commit
that referenced
this pull request
Jul 23, 2024
Add proper type hints to the two arguments in ViewInterface->assign(). This is not breaking since existing implementations can still accept "more" by not setting these arguments - method arguments of subtypes are contravariant. This will be backported to 2.14.
lolli42
added a commit
that referenced
this pull request
Jul 23, 2024
Add proper type hints to the two arguments in ViewInterface->assign(). This is not breaking since existing implementations can still accept "more" by not setting these arguments - method arguments of subtypes are contravariant. This will be backported to 2.14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper type hints to the two arguments
in ViewInterface->assign(). This is not
breaking since existing implementations can
still accept "more" by not setting these
arguments - method arguments of subtypes
are contravariant. This will be backported
to 2.14.