Remove all commands with no param #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@rgoliveira @TalAter kind of a must have. Lol |
TalAter
added a commit
that referenced
this pull request
May 25, 2014
Calling removeCommands with no arguments, removes all commands.
|
Looks good. I just did one change. The parameter to empty should be commandsList and not commandsToRemove. Thanks for the help! I would love to see how you guys use annyang. |
|
Great! Thank you, TalAter. I'm just playing around to see how this Speech API is working right now. If you want to check it out, I've set up a simple game on my website: http://rgoliveira.com/speech-adventure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no way to remove all commands unless you convert your original command list into an array.