Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translate] Adding Custom Sounds.md to Chinese #23

Merged

Conversation

WuZhuoran
Copy link
Contributor

Also fix some typo.

Copy link
Collaborator

@Bisstocuz Bisstocuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整个文本很多句子都有语序很奇怪的毛病,需要润色

@WuZhuoran
Copy link
Contributor Author

整个文本很多句子都有语序很奇怪的毛病,需要润色

哪些方面需要修改?是现在修改还是之后?

Copy link
Collaborator

@Bisstocuz Bisstocuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先处理这些吧,精修以后再来。
以下所有 comments 仅供参考,不一定要全部执行,请译者斟酌。

@@ -6,14 +6,14 @@ weight = 1
Bannerlord audio system is built on proprietary FMOD Sound system.
To keep audio engine performant while making it accessible to anyone, we needed to create an interlayer.
Copy link
Collaborator

@Bisstocuz Bisstocuz Oct 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTICE: This word "performant" in this line should be "performance".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I believe performant is the correct usage.

@OzgurEraslan OzgurEraslan merged commit 4f8a41c into TaleWorlds:master Oct 13, 2020
@WuZhuoran WuZhuoran deleted the docs-translate-Adding-Custom-Sounds branch October 19, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants