Skip to content

Add french language #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Add french language #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3132221
Add french language
Joilson Dec 8, 2020
343fe15
Fix unit test
Joilson Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions resources/languages/iso6391.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,8 @@
'name' => 'Portuguese',
'code' => 'pt',
],
'fr' => [
'name' => 'French',
'code' => 'fr',
],
];
5 changes: 5 additions & 0 deletions src/Geography/CountryList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,9 @@ public static function ES() : Country
{
return new Country('Spain', 'ES', 'ESP');
}

public static function FR() : Country
{
return new Country('France', 'FR', 'FRA');
}
}
1 change: 1 addition & 0 deletions tests/Geography/CountryListTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public function objectDataProvider() : array
[CountryList::BR(), ['Brazil', 'BR', 'BRA']],
[CountryList::US(), ['United States Of America', 'US', 'USA']],
[CountryList::ES(), ['Spain', 'ES', 'ESP']],
[CountryList::FR(), ['France', 'FR', 'FRA']],
];
}
}
2 changes: 1 addition & 1 deletion tests/Linguistics/Languages/ISO6391LanguagesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function testGetAll() : void
$results[] = $item;
}

$this->assertCount(3, $results);
$this->assertCount(4, $results);
$this->assertTrue(
(new Language('English', 'en'))->equals($results[0])
);
Expand Down