Fix: Ensure query collections initialize with existing data #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when creating a collection from a TanStack Query that already had data, the collection would remain stuck in the
loading
state until the query refreshed. This happens becauseQueryObserver
only invokes its callback on changes, not when attaching to an already-loaded query.The issue was especially visible for me with Fast Refresh: working locally, after a hot reload, all query state disappeared until the next time the queries refreshed.
This change makes the callback fire immediately with the current query state when we set up the observer, so collections correctly initialize with existing data. (As far as I could tell,
QueryObserver
doesn’t provide a built-in way to fire the callback automatically with initial state.)