-
Notifications
You must be signed in to change notification settings - Fork 102
feat: implement useLiveInfiniteQuery hook for React #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KyleAMathews
wants to merge
3
commits into
kevin/pred-pushdown-query-coll
Choose a base branch
from
use-live-infinite-query
base: kevin/pred-pushdown-query-coll
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: implement useLiveInfiniteQuery hook for React #666
KyleAMathews
wants to merge
3
commits into
kevin/pred-pushdown-query-coll
from
use-live-infinite-query
+919
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 248bdf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Size Change: 0 B Total Size: 76.9 kB ℹ️ View Unchanged
|
Size Change: 0 B Total Size: 1.46 kB ℹ️ View Unchanged
|
Implements Phase 1 of RFC #613 for infinite query pattern with live reactivity. - Add useLiveInfiniteQuery hook with TanStack Query-compatible API - Support pagination within collection's current dataset - Include pages, pageParams, fetchNextPage, hasNextPage - Automatically update pages when underlying data changes - Reset pagination when dependencies change - Add comprehensive test suite with 13 tests covering pagination, live updates, and edge cases Phase 1 uses client-side slicing. Future phases will add limit optimization and backend integration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…eQuery Ensures lastPage and lastPageParam are defined before passing to getNextPageParam to satisfy TypeScript strict checks.
cf96419
to
248bdf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements Phase 1 of RFC #613 (
useLiveInfiniteQuery
hook for React).This PR adds a new
useLiveInfiniteQuery
hook that combines TanStack Query's infinite query pattern with TanStack DB's live query reactivity. The hook provides a familiar API for pagination while automatically updating pages as underlying data changes.What's Included
New
useLiveInfiniteQuery
hook with TanStack Query-compatible APIpages
: Array of page arraysdata
: Flattened array of all loaded itemspageParams
: Array of page parameters usedfetchNextPage()
: Load the next pagehasNextPage
: Boolean indicating if more pages are availableuseLiveQuery
properties (status, isLoading, isReady, etc.)Automatic live updates: Pages update reactively when underlying data changes
Dependency tracking: Resets pagination when query dependencies change
Comprehensive test suite: 13 tests covering pagination, live updates, and edge cases
Implementation Details
Phase 1 Approach:
Future Phases:
Example Usage
Test Coverage
All 13 tests passing with 94% statement coverage.
Closes #613
🤖 Generated with Claude Code