-
-
Notifications
You must be signed in to change notification settings - Fork 514
fix(form-core): prevent FormApi#moveFieldValues
from mutating defaultValues
#1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form-core): prevent FormApi#moveFieldValues
from mutating defaultValues
#1560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Just a nitpick with the unit test, but the fix itself looks good to me!
935bb43
to
bb0af3c
Compare
bb0af3c
to
b58ca8e
Compare
FormApi#moveFieldValues
from mutating defaultValues
View your CI Pipeline Execution ↗ for commit 4a25c1f.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1560 +/- ##
=======================================
Coverage 89.24% 89.25%
=======================================
Files 31 31
Lines 1432 1433 +1
Branches 366 366
=======================================
+ Hits 1278 1279 +1
Misses 137 137
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for the fix! |
This PR addesses the following issue: #1559
💡 Open question: I don't know if other field array methods suffer from the same issue but, if some do, should we address those in this PR too?