Skip to content

Conversation

tmarnet
Copy link
Contributor

@tmarnet tmarnet commented Jun 6, 2025

This PR addesses the following issue: #1559

💡 Open question: I don't know if other field array methods suffer from the same issue but, if some do, should we address those in this PR too?

Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Just a nitpick with the unit test, but the fix itself looks good to me!

@tmarnet tmarnet force-pushed the fix/move-field-values-mutating-default-values branch from 935bb43 to bb0af3c Compare June 6, 2025 17:27
@tmarnet tmarnet force-pushed the fix/move-field-values-mutating-default-values branch from bb0af3c to b58ca8e Compare June 6, 2025 17:28
@LeCarbonator LeCarbonator changed the title fix(form-core): moveFieldValues mutates default values fix(form-core): prevent FormApi#moveFieldValues from mutating defaultValues Jun 6, 2025
Copy link

nx-cloud bot commented Jun 6, 2025

View your CI Pipeline Execution ↗ for commit 4a25c1f.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 19s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-06 17:48:15 UTC

Copy link

pkg-pr-new bot commented Jun 6, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1560

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1560

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1560

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1560

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1560

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1560

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1560

commit: 4a25c1f

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (77acb33) to head (4a25c1f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1560   +/-   ##
=======================================
  Coverage   89.24%   89.25%           
=======================================
  Files          31       31           
  Lines        1432     1433    +1     
  Branches      366      366           
=======================================
+ Hits         1278     1279    +1     
  Misses        137      137           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeCarbonator
Copy link
Contributor

Thanks for the fix!

@LeCarbonator LeCarbonator merged commit b9219b6 into TanStack:main Jun 6, 2025
6 checks passed
@tmarnet tmarnet deleted the fix/move-field-values-mutating-default-values branch June 6, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants