Skip to content

Conversation

harry-whorlow
Copy link
Contributor

@harry-whorlow harry-whorlow commented Sep 21, 2025

Implements @lukeed/uuid so we're not relying on crypto.getRandomValue in native environments.

Copy link

changeset-bot bot commented Sep 21, 2025

🦋 Changeset detected

Latest commit: 3782282

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@tanstack/form-core Minor
@tanstack/angular-form Patch
@tanstack/form-devtools Patch
@tanstack/lit-form Patch
@tanstack/react-form Patch
@tanstack/solid-form Patch
@tanstack/svelte-form Patch
@tanstack/vue-form Patch
@tanstack/react-form-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Sep 21, 2025

View your CI Pipeline Execution ↗ for commit 3782282

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 6s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-25 10:24:01 UTC

@harry-whorlow
Copy link
Contributor Author

harry-whorlow commented Sep 21, 2025

looks to fix #1744

Copy link

pkg-pr-new bot commented Sep 21, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1753

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1753

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1753

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1753

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1753

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1753

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1753

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1753

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1753

commit: 3782282

Copy link

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (6892ed0) to head (3782282).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   90.35%   90.47%   +0.11%     
==========================================
  Files          38       38              
  Lines        1752     1784      +32     
  Branches      444      451       +7     
==========================================
+ Hits         1583     1614      +31     
- Misses        149      150       +1     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harry-whorlow harry-whorlow marked this pull request as ready for review September 23, 2025 15:01
@harry-whorlow
Copy link
Contributor Author

harry-whorlow commented Sep 24, 2025

Somehow I missed some of my experimental code and it was included into the PR, this returns formId to a getter again

@harry-whorlow harry-whorlow force-pushed the native-compatible-uuid branch 2 times, most recently from 900030d to 47ce956 Compare September 24, 2025 20:24
@harry-whorlow harry-whorlow changed the title fix(core): move to @lukeed/uuid for native environments fix(core): move to native compatible uuid Sep 24, 2025
@harry-whorlow harry-whorlow merged commit c978946 into TanStack:main Sep 25, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants