Skip to content

Conversation

felipestanzani
Copy link
Contributor

@felipestanzani felipestanzani commented Sep 23, 2025

🎯 Changes

Add shadcn/ui examples to React UI Libraries documentation.
Remove the "lastName" from the example and rename "firstName" to "name" to improve the consistency, since the "lastName" was not used in the Mantine example, and "firstName" was not used in Material UI examples.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Copy link

changeset-bot bot commented Sep 23, 2025

⚠️ No Changeset found

Latest commit: b1538dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! The added descriptions are great, and there's only a small thing that needs to be discussed/resolved. Once that's done, I'll gladly add this to the docs.

autofix-ci bot and others added 2 commits September 24, 2025 05:57
Changes input defaultValue to value

Co-authored-by: LeCarbonator <18158911+LeCarbonator@users.noreply.github.com>
@felipestanzani
Copy link
Contributor Author

Your suggestion is correct. Thank you.

@LeCarbonator LeCarbonator merged commit 888bfcd into TanStack:main Sep 24, 2025
1 check passed
@LeCarbonator
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants