Skip to content

fixed(queryObserver): fetch data twice when mounted #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2020
Merged

fixed(queryObserver): fetch data twice when mounted #1320

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef205ed
Only work once when forceFetchOnMount is ture or refetchOnMount is 'a…
liaoliao666 Nov 23, 2020
49d9183
fixed(queryObserver): fetch data twice when mounted
liaoliao666 Nov 25, 2020
5c9a726
optimization(query): reduce unnecessary recursion
liaoliao666 Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/core/query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,12 @@ export class Query<TResult, TError> {
// Get the new data
let data: TResult | undefined = functionalUpdate(updater, prevData)

// Structurally share data between prev and new data if needed
if (this.config.structuralSharing) {
data = replaceEqualDeep(prevData, data)
}

// Use prev data if an isDataEqual function is defined and returns `true`
if (this.config.isDataEqual?.(prevData, data)) {
data = prevData
} else if (this.config.structuralSharing) {
// Structurally share data between prev and new data if needed
data = replaceEqualDeep(prevData, data)
}

// Try to determine if more data can be fetched
Expand Down