Skip to content

feat(broadcastQueryClient): experimental support for tab/window syncing #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 23, 2021
Merged

feat(broadcastQueryClient): experimental support for tab/window syncing #1793

merged 11 commits into from
Feb 23, 2021

Conversation

tannerlinsley
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Feb 13, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/Fb8nBCJkFXXoZxhhvMVZD3jozqAf
✅ Preview: https://react-query-git-feat-broadcastquerclient-experimental-f95bb7.vercel.app

@tannerlinsley tannerlinsley requested a review from TkDodo February 13, 2021 06:37
@tannerlinsley
Copy link
Collaborator Author

This PR relies on #1792

@tannerlinsley tannerlinsley marked this pull request as draft February 13, 2021 06:38
boschni
boschni reviewed Feb 13, 2021
View reviewed changes
TkDodo
TkDodo reviewed Feb 13, 2021
View reviewed changes
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: It seems that we are not syncing query-clients, but queries inside the query-cache? If that's the case, can we make this a bit more obvious in the docs? Settings like queryDefaults on the client would not be synced as far as I can tell.

Also: Does this work if I have two apps that use the same broadcastChannel? If so, do both apps need to call broadcastQueryClient, or is this meant for the same app opened in multiple browsers only?

@tannerlinsley tannerlinsley marked this pull request as ready for review February 15, 2021 18:50
TkDodo
TkDodo reviewed Feb 21, 2021
View reviewed changes
@tannerlinsley tannerlinsley requested a review from TkDodo February 22, 2021 15:31
@tannerlinsley tannerlinsley merged commit 4bbfe2a into master Feb 23, 2021
@tannerlinsley tannerlinsley deleted the feat-broadcastQuerClient-experimental branch February 23, 2021 04:26
@tannerlinsley
Copy link
Collaborator Author

🎉 This PR is included in version 3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

@boschni boschni Awaiting requested review from boschni

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannerlinsley @TkDodo @boschni