-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(devtools): update react query logo to close devtools #3577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e3ce97c:
|
@TkDodo We can also add padding to the query list to allow scrolling past overlapping queries if needed. |
I think its fine as-is. you can always hide the close button via props if you want to. |
added button wrapper on react query logo which onClick closes devtools window closes TanStack#3067
f630d9e
to
e3ce97c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3577 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 45 45
Lines 2278 2278
Branches 637 637
=======================================
Hits 2195 2195
Misses 80 80
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, thank you
🎉 This PR is included in version 3.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…tack#3577) * feat(devtools): update react query logo to close devtools added button wrapper on react query logo which onClick closes devtools window closes TanStack#3067 * feat(devtools): update test case for open and close devtools
🎉 This PR is included in version 4.0.0-beta.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is my favorite change in recent versions. Thank you! |
Description
Added button wrapper on react query logo which onClick closes devtools window
Verification Process
Tested locally
Applicable Issue
Closes #3067