Skip to content

feat(devtools): update react query logo to close devtools #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2022

Conversation

himankpathak
Copy link
Contributor

Description

Added button wrapper on react query logo which onClick closes devtools window

Verification Process

Tested locally

Applicable Issue

Closes #3067

@vercel
Copy link

vercel bot commented Apr 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-query ✅ Ready (Inspect) Visit Preview May 3, 2022 at 8:41AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e3ce97c:

Sandbox Source
tannerlinsley/react-query Configuration
tannerlinsley/react-query: basic-typescript Configuration

@himankpathak
Copy link
Contributor Author

@TkDodo We can also add padding to the query list to allow scrolling past overlapping queries if needed.

image

@TkDodo
Copy link
Collaborator

TkDodo commented May 1, 2022

We can also add padding to the query list to allow scrolling past overlapping queries if needed.

I think its fine as-is. you can always hide the close button via props if you want to.

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #3577 (e3ce97c) into master (07c9ce0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3577   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          45       45           
  Lines        2278     2278           
  Branches      637      637           
=======================================
  Hits         2195     2195           
  Misses         80       80           
  Partials        3        3           
Impacted Files Coverage Δ
src/devtools/devtools.tsx 78.78% <100.00%> (+0.10%) ⬆️
src/core/queryObserver.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c9ce0...e3ce97c. Read the comment docs.

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, thank you

@TkDodo TkDodo merged commit 5848fab into TanStack:master May 8, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@himankpathak himankpathak deleted the feat/devtools branch May 8, 2022 08:28
MMMikeM pushed a commit to MMMikeM/react-query that referenced this pull request May 23, 2022
…tack#3577)

* feat(devtools): update react query logo to close devtools

added button wrapper on react query logo which onClick closes devtools window

closes TanStack#3067

* feat(devtools): update test case for open and close devtools
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@IanVS
Copy link
Contributor

IanVS commented Jul 13, 2022

This is my favorite change in recent versions. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ReactQueryDevtools] Handle in a better way the "close" button
4 participants