fix(query): updating with setQueryData should not affect fetchStatus #3613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queries can be fetching _while_ we are making a manual update are still fetching, so we have to set fields that affect the fetch conditionally (fetchStatus, fetchFailureCount)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6df2ef2:
|
|
@lgenzelis fyi |
fix logical condition that I screwed up; thank you, tests
Codecov Report
@@ Coverage Diff @@
## beta #3613 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 48 48
Lines 2382 2383 +1
Branches 709 709
=======================================
+ Hits 2309 2310 +1
Misses 71 71
Partials 2 2
Continue to review full report at Codecov.
|
TkDodo
deleted the
feature/3594-setQueryData-incorrectly-resets-isFetching
branch
|
🎉 This PR is included in version 4.0.0-beta.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queries can be fetching while we are making a manual update are still fetching, so we have to set fields that affect the fetch conditionally (fetchStatus, fetchFailureCount)
fixes #3594